Skip to content

CHORE: Update pre-commit hooks and intend to fix auto update #6058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 18, 2025

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Apr 17, 2025

Description

Manual update of the pre-commit hooks and intend to fix our issue of not having automatic update any more. Latest automatic PR was in 2024 and associated to 015b380 ...

Note that we can't use the latest version of the ansys/pre-commit-hooks as any version >=v0.5.1 fails in our current cfg.

Issue linked

#5524

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@SMoraisAnsys SMoraisAnsys self-assigned this Apr 17, 2025
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.14%. Comparing base (a07adbc) to head (24f519e).
Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6058      +/-   ##
==========================================
+ Coverage   82.43%   85.14%   +2.71%     
==========================================
  Files         167      167              
  Lines       63041    63041              
==========================================
+ Hits        51968    53677    +1709     
+ Misses      11073     9364    -1709     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SMoraisAnsys SMoraisAnsys enabled auto-merge (squash) April 18, 2025 10:00
@SMoraisAnsys SMoraisAnsys merged commit 8faf545 into main Apr 18, 2025
30 of 31 checks passed
@SMoraisAnsys SMoraisAnsys deleted the chore/fix-precommit-ci-update branch April 18, 2025 10:08
nunesanderson pushed a commit that referenced this pull request Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants