Skip to content

REFACTOR: Pathlib hfss3dlayout.py #6057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 21, 2025
Merged

Conversation

jvela018
Copy link
Contributor

Issue linked

#5180

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.14%. Comparing base (59db6de) to head (85eb77a).
Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (76.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6057   +/-   ##
=======================================
  Coverage   85.14%   85.14%           
=======================================
  Files         167      167           
  Lines       63041    63040    -1     
=======================================
+ Hits        53675    53677    +2     
+ Misses       9366     9363    -3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hui-zhou-a
Copy link
Contributor

@jvela018 thanks for the contribution! If you have time, please also help to improve codecy coverage.

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) April 21, 2025 10:37
@Samuelopez-ansys Samuelopez-ansys merged commit 166495a into main Apr 21, 2025
29 of 30 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the refactor/pathlib/hfss3dlayout branch April 21, 2025 11:49
nunesanderson pushed a commit that referenced this pull request Apr 30, 2025
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Samuel Lopez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants