-
Notifications
You must be signed in to change notification settings - Fork 161
REFACTOR: Add examples folder and rework download logic #6055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6055 +/- ##
==========================================
- Coverage 85.14% 85.13% -0.01%
==========================================
Files 167 167
Lines 63040 63056 +16
==========================================
+ Hits 53674 53685 +11
- Misses 9366 9371 +5 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Samuelopez-ansys @MaxJPRey Let's wait a bit before merging to see if the pyaedt-examples are not impacted. I'll open a PR to test that :) |
This reverts commit 07827c1.
…)" This reverts commit 1395f94.
Co-authored-by: pyansys-ci-bot <[email protected]> Co-authored-by: Maxime Rey <[email protected]> Co-authored-by: Samuel Lopez <[email protected]>
Description
This PR consists in refactoring the downloads logic. While doing so, an architecture refactoring was performed and a folder
examples
is now underansys.aedt.core
. It contains the modifieddowloads.py
module and can be extended with other actions related to the examples.The download refactoring consist in:
github_relative_path
to provide the path to the file/folder in github, use inputfilter_func
to specify files/folders to be filtered, usestrip_prefix
to remove the original structure (e.g. allowing to download the file"pyaedt/edb/Galileo.aedb/GRM32ER72A225KA35_25C_0V.sp"
without creating locally"pyaedt/edb/Galileo.aedb"
);Issue linked
Associated to #5504
Checklist