Skip to content

REFACTOR: move add calculation to CommonOptimetrics #6030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 10, 2025

Conversation

gmalinve
Copy link
Contributor

@gmalinve gmalinve commented Apr 10, 2025

Description

Move add_calculation to CommonOptimetrics and remove _add_goal because it's not use anywhere.
add_goal method uses _add_calculation (in CommonOptimetrics). _add_goal was redundant.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@gmalinve gmalinve self-assigned this Apr 10, 2025
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@gmalinve gmalinve linked an issue Apr 10, 2025 that may be closed by this pull request
@gmalinve gmalinve requested a review from maxcapodi78 April 10, 2025 12:17
@gmalinve gmalinve marked this pull request as ready for review April 10, 2025 12:17
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.13%. Comparing base (9095b51) to head (1c7e7d9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6030      +/-   ##
==========================================
+ Coverage   85.08%   85.13%   +0.05%     
==========================================
  Files         166      166              
  Lines       62977    62936      -41     
==========================================
- Hits        53583    53581       -2     
+ Misses       9394     9355      -39     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmalinve gmalinve merged commit eefb51d into main Apr 10, 2025
43 checks passed
@gmalinve gmalinve deleted the refactor/move_add_calculation branch April 10, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move add_calculation in CommonOptimetrics
3 participants