Skip to content

DOCS: Add log and nosec in checked subprocess calls #6001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2025

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Apr 3, 2025

Description

Just checked the files used to be executed as python script to install things through AEDT.
Adding a log message when using a specific environment variable and # nosec on subprocess calls otherwise.

Issue linked

#5504

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@SMoraisAnsys SMoraisAnsys changed the title DOCS: Add nosec in checked subprocess calls DOCS: Add long and nosec in checked subprocess calls Apr 3, 2025
@SMoraisAnsys SMoraisAnsys changed the title DOCS: Add long and nosec in checked subprocess calls DOCS: Add log and nosec in checked subprocess calls Apr 3, 2025
@SMoraisAnsys SMoraisAnsys self-assigned this Apr 3, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 3, 2025
MaxJPRey
MaxJPRey previously approved these changes Apr 3, 2025
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.05%. Comparing base (fa1643f) to head (2503f2a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6001      +/-   ##
==========================================
- Coverage   85.06%   85.05%   -0.01%     
==========================================
  Files         165      165              
  Lines       62906    62906              
==========================================
- Hits        53510    53504       -6     
- Misses       9396     9402       +6     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SMoraisAnsys SMoraisAnsys dismissed stale reviews from Samuelopez-ansys and MaxJPRey via 2503f2a April 3, 2025 17:08
@Samuelopez-ansys Samuelopez-ansys merged commit 811c035 into main Apr 4, 2025
43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the doc/update-installer-scripts branch April 4, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants