Skip to content

FIX: Copy Design #5623 #5993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 2, 2025
Merged

FIX: Copy Design #5623 #5993

merged 8 commits into from
Apr 2, 2025

Conversation

Devin-Crawford
Copy link
Contributor

Description

  • copy_design_from updates the current design correctly.
  • Added get_example() to desktop to retrieve the path of an example file.
  • Update unit test.

Issue linked

Resolve #5992 and #5623.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

- copy_design_from updates the current design correctly.
- Added get_example() to desktop to retrieve the path
  of an example file #5992
- Update unit test.
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@Devin-Crawford Devin-Crawford changed the title Fix #5623 FIX: Copy Design #5623 Apr 2, 2025
@github-actions github-actions bot added the bug Something isn't working label Apr 2, 2025
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.07%. Comparing base (a8ec659) to head (80a6e1d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5993   +/-   ##
=======================================
  Coverage   85.07%   85.07%           
=======================================
  Files         165      165           
  Lines       62879    62892   +13     
=======================================
+ Hits        53493    53508   +15     
+ Misses       9386     9384    -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SMoraisAnsys
SMoraisAnsys previously approved these changes Apr 2, 2025
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left minor comments

@Samuelopez-ansys Samuelopez-ansys dismissed stale reviews from SMoraisAnsys and themself via 806e953 April 2, 2025 12:06
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) April 2, 2025 12:09
@Samuelopez-ansys Samuelopez-ansys merged commit 8ae564c into main Apr 2, 2025
46 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/copy_design_from_5623 branch April 2, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add property for the installation folder.
4 participants