-
Notifications
You must be signed in to change notification settings - Fork 161
REFACTOR: Improve API and security in Desktop #5892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR: Improve API and security in Desktop #5892
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (78.57%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5892 +/- ##
==========================================
+ Coverage 85.10% 85.11% +0.01%
==========================================
Files 165 165
Lines 62807 62812 +5
==========================================
+ Hits 53449 53461 +12
+ Misses 9358 9351 -7 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
@Samuelopez-ansys @maxcapodi78 This is ready :) |
Co-authored-by: Samuel Lopez <[email protected]>
Description
The PR consist in a refactoring of the desktop module to clean it and strengthen the calls related to subprocess. On top of that, a new section has been added to the documentation to notify about the risk of using insecure commands.
Changes are:
__
method instead of_
method when it makes sense;Issue linked
#5504
Checklist