Skip to content

Fix default setups #4564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Fix default setups #4564

merged 5 commits into from
Apr 23, 2024

Conversation

lorenzovecchietti
Copy link
Contributor

@lorenzovecchietti lorenzovecchietti commented Apr 22, 2024

Close #4567

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Apr 22, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.52%. Comparing base (2615a70) to head (3893fb3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4564   +/-   ##
=======================================
  Coverage   81.51%   81.52%           
=======================================
  Files         110      110           
  Lines       53746    53746           
=======================================
+ Hits        43812    43816    +4     
+ Misses       9934     9930    -4     

@lorenzovecchietti lorenzovecchietti marked this pull request as ready for review April 22, 2024 11:16
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit 49f567f into main Apr 23, 2024
15 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix_default_setups branch April 23, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default setups contain ":="
3 participants