Skip to content

Lumped RLC boundary supports both parallel and serial type. #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

MaxJPRey
Copy link
Collaborator

RLC type is a string argument and not a list.
Fix #1336 .
Adding some unit tests to cover the serial lumped ports.

@github-actions github-actions bot added the bug Something isn't working label Jun 29, 2022
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #1342 (3a804e1) into main (8b8e784) will increase coverage by 0.02%.
The diff coverage is 93.45%.

@@            Coverage Diff             @@
##             main    #1342      +/-   ##
==========================================
+ Coverage   79.09%   79.12%   +0.02%     
==========================================
  Files          97       97              
  Lines       39588    39632      +44     
==========================================
+ Hits        31314    31357      +43     
- Misses       8274     8275       +1     

@MaxJPRey MaxJPRey requested a review from maxcapodi78 June 29, 2022 20:59
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaxJPRey MaxJPRey merged commit d11f516 into main Jun 30, 2022
@MaxJPRey MaxJPRey deleted the fix/issue_1336 branch June 30, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assigning Lumped RLC
2 participants