Skip to content

Props getitem and setitem #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 28, 2022
Merged

Props getitem and setitem #1338

merged 6 commits into from
Jun 28, 2022

Conversation

maxcapodi78
Copy link
Collaborator

@maxcapodi78 maxcapodi78 commented Jun 28, 2022

Now user can get or set a property directly from the objects thanks to getitem and setitem

@maxcapodi78 maxcapodi78 changed the title Props improvement Props getitem and setitem Jun 28, 2022
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #1338 (a98b9a3) into main (8b8e784) will increase coverage by 0.01%.
The diff coverage is 92.76%.

@@            Coverage Diff             @@
##             main    #1338      +/-   ##
==========================================
+ Coverage   79.09%   79.11%   +0.01%     
==========================================
  Files          97       97              
  Lines       39588    39637      +49     
==========================================
+ Hits        31314    31358      +44     
- Misses       8274     8279       +5     

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is really great

Copy link
Contributor

@Alberto-DM Alberto-DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxcapodi78 maxcapodi78 enabled auto-merge (squash) June 28, 2022 16:21
@maxcapodi78 maxcapodi78 merged commit 1e694c2 into main Jun 28, 2022
@maxcapodi78 maxcapodi78 deleted the props_improvement branch June 28, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants