Skip to content

read motion setup in Maxwell2D #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 24, 2022
Merged

Conversation

gmalinve
Copy link
Contributor

read MotionSetup when getting boundaries data in Design

@gmalinve gmalinve self-assigned this Jun 22, 2022
@gmalinve gmalinve requested a review from maxcapodi78 June 22, 2022 15:01
@gmalinve gmalinve linked an issue Jun 22, 2022 that may be closed by this pull request
2 tasks
@gmalinve gmalinve marked this pull request as draft June 22, 2022 16:08
@gmalinve
Copy link
Contributor Author

check "ModelSetup" in Q2D -> test_30_Q2D.
Check other solvers.

@gmalinve gmalinve marked this pull request as ready for review June 23, 2022 09:34
@gmalinve gmalinve marked this pull request as draft June 23, 2022 09:35
@gmalinve gmalinve marked this pull request as ready for review June 23, 2022 10:23
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #1324 (3c0d1e0) into main (38b6cdf) will increase coverage by 1.22%.
The diff coverage is 72.68%.

@@            Coverage Diff             @@
##             main    #1324      +/-   ##
==========================================
+ Coverage   77.87%   79.09%   +1.22%     
==========================================
  Files          97       97              
  Lines       39444    39588     +144     
==========================================
+ Hits        30717    31314     +597     
+ Misses       8727     8274     -453     

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxcapodi78 maxcapodi78 merged commit 2388faa into main Jun 24, 2022
@maxcapodi78 maxcapodi78 deleted the read_motion_setup_maxwell_2d branch June 24, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Motion is not read in Maxwell 2D
3 participants