-
Notifications
You must be signed in to change notification settings - Fork 164
Implemented new method to get all available report quantities categories and all report quantities. #1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies and all report quantities. Furthermore now the report_by_templates classes supports None expression as argument as they will take all quantities of default category. Added method to identify if a setup or a sweep is solved or not by checking the solution data.
Codecov Report
@@ Coverage Diff @@
## main #1323 +/- ##
==========================================
+ Coverage 77.87% 79.11% +1.23%
==========================================
Files 97 97
Lines 39444 39527 +83
==========================================
+ Hits 30717 31271 +554
+ Misses 8727 8256 -471 |
Samuelopez-ansys
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great!
MaxJPRey
reviewed
Jun 22, 2022
MaxJPRey
reviewed
Jun 22, 2022
MaxJPRey
reviewed
Jun 22, 2022
MaxJPRey
approved these changes
Jun 22, 2022
LGTM. |
…m/pyansys/pyaedt into reports_categories_and_quantities
cmesibov
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Furthermore now the report_by_templates classes supports None expression as argument as they will take all quantities of default category.
Added method to identify if a setup or a sweep is solved or not by checking the solution data.