Fix bounding box extent

[ghost]

A comment and a question up front:

• I welcome comments on the validate_enum_class_value design as I'm not sure if this is particularly pythonic or if there is a standard or better way to do it.
• Should these setters raise a ValueError or other exception if the validation fails? This is not being done currently and the values not set are silently ignored.

The setters for some SimulationConfiguration properties, including cutout_subdesign_type, radiation_box, sweep_type, and basis_order would never set their property's value because they were checking that the arguments were of a type that would not be passed in. The arguments passed in are integers taken from attributes on the class. I call these "enumeration style" classes.

To fix this, add a new method validate_enum_class_value that takes an enumeration style class "cls" that has valid values from zero to N where the value N is assigned to the class attribute called Invalid and an integer value "value" to validate. The function returns true if "value" is between zero (inclusive) and cls.Invalid (exclusive). Note that the enumeration class must define this Invalid attribute and its value is not itself valid.

I added a test for setting the boundary box extent type which is the case that was reported to me as not working.

Fixes #1313

[codecov]

Codecov Report

Merging #1314 (d071594) into main (30a7b15) will increase coverage by 1.33%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1314      +/-   ##
==========================================
+ Coverage   77.87%   79.20%   +1.33%     
==========================================
  Files          97       97              
  Lines       39443    39824     +381     
==========================================
+ Hits        30716    31543     +827     
+ Misses       8727     8281     -446     

[maxcapodi78]

@isaacansys I like this approach. Since the number of enum in edb is quite high I would probably create a separate module in edb_core folder and have a method also to retrieve the enum value given an int and an edb class. that would be replaced in all the methods that requires it as input

[ghost]

Thanks all for suggestions, have a busy calendar today but will get these incorporated by tomorrow and ready to merge.

[maxcapodi78]

@isaacansys if you finalize all agreed changes we can close this PR