Edit Sources in Q3D and Q2D #1298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Samuelopez-ansys
commented
Jun 16, 2022
Samuelopez-ansys
commented
- Allow unit value A_per_m and A_per_meter
- New Q3D and Q2D method for Edit Sources. Bug in AEDT API found. In Q3D it is not possible to modify the phase.
- New Q3D and Q2D method for Edit Sources. Bug in AEDT API found. In Q3D it is not possible to modify the phase.
Closed
2 tasks
|
Found a bug in AEDT API for Q3D. It is not possible to modify the phase of the source, I submitted a bug already. |
Codecov Report
@@ Coverage Diff @@
## main #1298 +/- ##
==========================================
- Coverage 77.77% 77.68% -0.09%
==========================================
Files 96 96
Lines 38512 38741 +229
==========================================
+ Hits 29951 30095 +144
- Misses 8561 8646 +85 |
maxcapodi78
approved these changes
Jun 16, 2022
PipKat
reviewed
Jun 16, 2022
PipKat
reviewed
Jun 16, 2022
Comment on lines
+212
to
+213
| - 1 Value to setup 0deg as default or | ||
| - 2 values tuple or list (magnitude and phase). |
There was a problem hiding this comment.
Suggested change
| - 1 Value to setup 0deg as default or | |
| - 2 values tuple or list (magnitude and phase). | |
| - 1 Value to set up ``0deg`` as the default | |
| - 2 A values tuple or list (magnitude and phase) |
PipKat
reviewed
Jun 16, 2022
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.