Test for IronPython before importing numpy #1292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bare import of numpy in python_optimizers.py would cause failures in IronPython or AEDT. Use the same logic from elsewhere to avoid.
ghost
requested review from
MaxJPRey
approved these changes
Jun 15, 2022
|
LGTM. |
Codecov Report
@@ Coverage Diff @@
## main #1292 +/- ##
==========================================
- Coverage 77.78% 77.77% -0.01%
==========================================
Files 96 96
Lines 38558 38564 +6
==========================================
+ Hits 29992 29994 +2
- Misses 8566 8570 +4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bare import of numpy in python_optimizers.py would cause failures in
IronPython or AEDT. Use the same logic from elsewhere to avoid.
Fixes #1291