Skip to content

fix eddy effects Maxwell 2D #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2022
Merged

fix eddy effects Maxwell 2D #1246

merged 1 commit into from
Jun 7, 2022

Conversation

gmalinve
Copy link
Contributor

@gmalinve gmalinve commented Jun 6, 2022

No description provided.

@gmalinve gmalinve requested a review from maxcapodi78 June 6, 2022 10:01
@gmalinve gmalinve self-assigned this Jun 6, 2022
@gmalinve gmalinve linked an issue Jun 6, 2022 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #1246 (adff438) into main (ae89691) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1246      +/-   ##
==========================================
+ Coverage   77.58%   77.59%   +0.01%     
==========================================
  Files          96       96              
  Lines       37776    37784       +8     
==========================================
+ Hits        29307    29318      +11     
+ Misses       8469     8466       -3     

Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmalinve gmalinve merged commit dacae63 into main Jun 7, 2022
@gmalinve gmalinve deleted the Maxwell2D_eddy_effects branch June 7, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maxwell2d.eddy_effects_on() gives errors if used in transient
2 participants