Export mesh exception for Q3D API #1231
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1231 +/- ##
==========================================
+ Coverage 77.59% 77.62% +0.03%
==========================================
Files 96 96
Lines 37710 37778 +68
==========================================
+ Hits 29261 29326 +65
- Misses 8449 8452 +3 |
pyaedt/application/Analysis3D.py
Outdated
| @@ -250,7 +250,7 @@ def plot( | |||
| ) | |||
|
|
|||
| @pyaedt_function_handler() | |||
| def export_mesh_stats(self, setup_name, variation_string="", mesh_path=None): | |||
| def export_mesh_stats(self, setup_name, variation_string="", mesh_path=None, setup_type="CG"): | |||
There was a problem hiding this comment.
is it good to put Q3D specific parts into general function?
@maxcapodi78
your thoughts?
There was a problem hiding this comment.
Another option could be to create a different method only for Q3D...
There was a problem hiding this comment.
don't know. However, changing signature just because of Q3D.
from other side over-complicating things is also not good
There was a problem hiding this comment.
Hi @maxcapodi78 , could you check if this PR makes sense? Or should I create a different method for Q3D? Thanks!
There was a problem hiding this comment.
I have created an overridden method in q3d.py, to keep the original one. But the Codacy is complaining because I added one parameter that is not available in the original method, any suggestion? should I rename the method in q3d.py to avoid this issue? Thanks! @maxcapodi78 @beliaev-maksim
No description provided.