-
Notifications
You must be signed in to change notification settings - Fork 164
Add 3d stackup creation class #1198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # pyaedt/modeler/Primitives.py
…nto add_3d_stackup_creation_class
pyaedt/modeler/stackup_3d.py
Outdated
|
||
@property | ||
def frequency(self): | ||
"""Model Frequency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"""Model Frequency. | |
"""Model frequency. |
pyaedt/modeler/stackup_3d.py
Outdated
|
||
@property | ||
def substrate_thickness(self): | ||
"""Substrate Thickness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"""Substrate Thickness. | |
"""Substrate thickness. |
pyaedt/modeler/stackup_3d.py
Outdated
Returns | ||
------- | ||
:class:`pyaedt.modeler.stackup_3d.NamedVariable` | ||
Variable Object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable Object. | |
Variable object. |
pyaedt/modeler/stackup_3d.py
Outdated
|
||
@property | ||
def position_x(self): | ||
"""Starting Position X. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"""Starting Position X. | |
"""Starting position X. |
pyaedt/modeler/stackup_3d.py
Outdated
Returns | ||
------- | ||
:class:`pyaedt.modeler.stackup_3d.NamedVariable` | ||
Variable Object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable Object. | |
Variable object. |
pyaedt/modeler/stackup_3d.py
Outdated
|
||
@property | ||
def position_y(self): | ||
"""Starting Position Y. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"""Starting Position Y. | |
"""Starting position Y. |
pyaedt/modeler/stackup_3d.py
Outdated
Returns | ||
------- | ||
:class:`pyaedt.modeler.stackup_3d.NamedVariable` | ||
Variable Object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable Object. | |
Variable object. |
pyaedt/modeler/stackup_3d.py
Outdated
Returns | ||
------- | ||
:class:`pyaedt.modeler.stackup_3d.NamedVariable` | ||
Variable Object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable Object. | |
Variable object. |
pyaedt/modeler/stackup_3d.py
Outdated
|
||
@property | ||
def _permittivity_calcul(self): | ||
"""Permittivity Calutation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"""Permittivity Calutation. | |
"""Permittivity calculation. |
pyaedt/modeler/stackup_3d.py
Outdated
Returns | ||
------- | ||
:class:`pyaedt.modeler.stackup_3d.NamedVariable` | ||
Variable Object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable Object. | |
Variable object. |
pyaedt/modeler/stackup_3d.py
Outdated
Returns | ||
------- | ||
:class:`pyaedt.modeler.stackup_3d.NamedVariable` | ||
Variable Object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable Object. | |
Variable object. |
pyaedt/modeler/stackup_3d.py
Outdated
|
||
@property | ||
def effective_permittivity(self): | ||
"""Effective Permittivity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"""Effective Permittivity. | |
"""Effective permittivity. |
pyaedt/modeler/stackup_3d.py
Outdated
|
||
@property | ||
def added_length(self): | ||
"""Added Length Calutation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"""Added Length Calutation. | |
"""Added length calculation. |
pyaedt/modeler/stackup_3d.py
Outdated
Returns | ||
------- | ||
:class:`pyaedt.modeler.stackup_3d.NamedVariable` | ||
Variable Object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable Object. | |
Variable object. |
pyaedt/modeler/stackup_3d.py
Outdated
|
||
@property | ||
def _added_length_calcul(self): | ||
"""Added Length Calutation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"""Added Length Calutation. | |
"""Added length calculation. |
pyaedt/modeler/stackup_3d.py
Outdated
Returns | ||
------- | ||
:class:`pyaedt.modeler.stackup_3d.NamedVariable` | ||
Variable Object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable Object. | |
Variable object. |
pyaedt/modeler/stackup_3d.py
Outdated
|
||
@property | ||
def wave_length(self): | ||
"""Wave Length. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"""Wave Length. | |
"""Wave length. |
@maxcapodi78 I didn't get through this entire PR and have to quite to get to a personal event. The big take-away is to use a verb ending in an "s" for a class description and generally use lower-case in descriptions. If this PR is still not merged when I get in tomorrow, I will continue my editorial review. Let me know. Thanks! |
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
…ansys/pyaedt into add_3d_stackup_creation_class
@PipKat I've to close it but I'm opening a new branch for enhancement on this classes. I will add you as reviewer in that PR. Thank you for the great work |
No description provided.