Skip to content

Add 3d stackup creation class #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 54 commits into from
May 20, 2022
Merged

Add 3d stackup creation class #1198

merged 54 commits into from
May 20, 2022

Conversation

maxcapodi78
Copy link
Collaborator

No description provided.

@maxcapodi78 maxcapodi78 requested a review from jeremich41 May 18, 2022 18:03

@property
def frequency(self):
"""Model Frequency.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Model Frequency.
"""Model frequency.


@property
def substrate_thickness(self):
"""Substrate Thickness.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Substrate Thickness.
"""Substrate thickness.

Returns
-------
:class:`pyaedt.modeler.stackup_3d.NamedVariable`
Variable Object.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Variable Object.
Variable object.


@property
def position_x(self):
"""Starting Position X.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Starting Position X.
"""Starting position X.

Returns
-------
:class:`pyaedt.modeler.stackup_3d.NamedVariable`
Variable Object.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Variable Object.
Variable object.


@property
def position_y(self):
"""Starting Position Y.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Starting Position Y.
"""Starting position Y.

Returns
-------
:class:`pyaedt.modeler.stackup_3d.NamedVariable`
Variable Object.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Variable Object.
Variable object.

Returns
-------
:class:`pyaedt.modeler.stackup_3d.NamedVariable`
Variable Object.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Variable Object.
Variable object.


@property
def _permittivity_calcul(self):
"""Permittivity Calutation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Permittivity Calutation.
"""Permittivity calculation.

Returns
-------
:class:`pyaedt.modeler.stackup_3d.NamedVariable`
Variable Object.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Variable Object.
Variable object.

Returns
-------
:class:`pyaedt.modeler.stackup_3d.NamedVariable`
Variable Object.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Variable Object.
Variable object.


@property
def effective_permittivity(self):
"""Effective Permittivity.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Effective Permittivity.
"""Effective permittivity.


@property
def added_length(self):
"""Added Length Calutation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Added Length Calutation.
"""Added length calculation.

Returns
-------
:class:`pyaedt.modeler.stackup_3d.NamedVariable`
Variable Object.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Variable Object.
Variable object.


@property
def _added_length_calcul(self):
"""Added Length Calutation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Added Length Calutation.
"""Added length calculation.

Returns
-------
:class:`pyaedt.modeler.stackup_3d.NamedVariable`
Variable Object.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Variable Object.
Variable object.


@property
def wave_length(self):
"""Wave Length.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Wave Length.
"""Wave length.

@PipKat
Copy link
Member

PipKat commented May 19, 2022

@maxcapodi78 I didn't get through this entire PR and have to quite to get to a personal event. The big take-away is to use a verb ending in an "s" for a class description and generally use lower-case in descriptions. If this PR is still not merged when I get in tomorrow, I will continue my editorial review. Let me know. Thanks!

@maxcapodi78 maxcapodi78 merged commit a3f3e49 into main May 20, 2022
@maxcapodi78 maxcapodi78 deleted the add_3d_stackup_creation_class branch May 20, 2022 07:46
@maxcapodi78
Copy link
Collaborator Author

maxcapodi78 commented May 20, 2022

@maxcapodi78 I didn't get through this entire PR and have to quite to get to a personal event. The big take-away is to use a verb ending in an "s" for a class description and generally use lower-case in descriptions. If this PR is still not merged when I get in tomorrow, I will continue my editorial review. Let me know. Thanks!

@PipKat I've to close it but I'm opening a new branch for enhancement on this classes. I will add you as reviewer in that PR. Thank you for the great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants