Skip to content

Spatial Modifier #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 19, 2022
Merged

Spatial Modifier #1196

merged 8 commits into from
May 19, 2022

Conversation

Samuelopez-ansys
Copy link
Member

  • New Spatial modifier method.
  • Thermal modifier bugs fixed

- Fix bug for thermal modifier. It material property was not defined in AEDT file, thermal modifier was not applied.
- Fix bug with Auto TML
- Add option to have thermal and spatial modifier in the same property
@Samuelopez-ansys Samuelopez-ansys linked an issue May 18, 2022 that may be closed by this pull request
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #1196 (a13d791) into main (0623855) will increase coverage by 0.15%.
The diff coverage is 89.13%.

@@            Coverage Diff             @@
##             main    #1196      +/-   ##
==========================================
+ Coverage   80.80%   80.95%   +0.15%     
==========================================
  Files         135      135              
  Lines       44178    44276      +98     
==========================================
+ Hits        35697    35845     +148     
+ Misses       8481     8431      -50     

Copy link
Contributor

@Alberto-DM Alberto-DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
One comment left

@Samuelopez-ansys Samuelopez-ansys merged commit c0d67ff into main May 19, 2022
@Samuelopez-ansys Samuelopez-ansys deleted the fix_issue1180 branch May 19, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Material Spatial Modifier
3 participants