Skip to content

Various fixes and improvements #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 19, 2022
Merged

Various fixes and improvements #1194

merged 8 commits into from
May 19, 2022

Conversation

Alberto-DM
Copy link
Contributor

Added SingleValue variation in parametric.
Added sync_variables option.
Fixed variable management for Circuit.
Created value_with_units = _arg_with_dim at Analysis level.
Improved variable mapping in assign_em_losses.
Fix in Varialbes for arrays. 
Fix in icepak apply_icepak_settings.
Other small bug-fixes and improvements.

Added sync_variables option.
Fixed variable management for Circuit.
Created value_with_units = _arg_with_dim at Analysis level.
Improved variable mapping in assign_em_losses.
Other small bug-fixes and improvements.
# Conflicts:
#	pyaedt/application/Analysis.py
#	pyaedt/modules/DesignXPloration.py
Added UI and docstring.
@Alberto-DM Alberto-DM marked this pull request as ready for review May 18, 2022 14:40
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #1194 (6a5b45a) into main (c0d67ff) will increase coverage by 0.02%.
The diff coverage is 89.14%.

@@            Coverage Diff             @@
##             main    #1194      +/-   ##
==========================================
+ Coverage   80.95%   80.98%   +0.02%     
==========================================
  Files         135      135              
  Lines       44276    44346      +70     
==========================================
+ Hits        35845    35912      +67     
- Misses       8431     8434       +3     

Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alberto-DM Alberto-DM merged commit 8206f7e into main May 19, 2022
@Alberto-DM Alberto-DM deleted the ADM_fixes_3 branch May 19, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants