Skip to content

Import 1D and 3D dataset method #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2022
Merged

Import 1D and 3D dataset method #1177

merged 3 commits into from
May 12, 2022

Conversation

Samuelopez-ansys
Copy link
Member

Import dataset method

- 1D and 3D file import
- Unittest
- Fix bug in pyaedt related to AEDT API change in 2022R1
@Samuelopez-ansys Samuelopez-ansys linked an issue May 12, 2022 that may be closed by this pull request
@Samuelopez-ansys Samuelopez-ansys added the enhancement New features or code improvements label May 12, 2022
@Samuelopez-ansys
Copy link
Member Author

Hi @MaxJPRey ,

The test is failing to install pyaedt, please could you help to identify the issue?

Thanks

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1177 (223360b) into main (5516fd2) will increase coverage by 0.03%.
The diff coverage is 89.13%.

@@            Coverage Diff             @@
##             main    #1177      +/-   ##
==========================================
+ Coverage   80.64%   80.67%   +0.03%     
==========================================
  Files         134      134              
  Lines       43704    43786      +82     
==========================================
+ Hits        35243    35323      +80     
- Misses       8461     8463       +2     

@MaxJPRey
Copy link
Collaborator

Hi @MaxJPRey ,

The test is failing to install pyaedt, please could you help to identify the issue?

Thanks

The issue was the pip install option --use-feature=in-tree-build removed which was preventing the installation of the pyaedt package. @maxcapodi78 fixed it.

@MaxJPRey
Copy link
Collaborator

@Samuelopez-ansys If possible, can you add more info in the title of the PR as it is used in the release notes.

Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys changed the title Fix issue1176 Import 1D and 3D dataset method May 12, 2022
@Samuelopez-ansys Samuelopez-ansys merged commit f452b78 into main May 12, 2022
@Samuelopez-ansys Samuelopez-ansys deleted the fix_issue1176 branch May 12, 2022 15:49
@MaxJPRey
Copy link
Collaborator

@Samuelopez-ansys If possible, can you add more info in the title of the PR as it is used in the release notes.

Thanks @Samuelopez-ansys .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import dataset
3 participants