Skip to content

fix assign_winding and assign_coil + update tests #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2022
Merged

fix assign_winding and assign_coil + update tests #1147

merged 1 commit into from
May 5, 2022

Conversation

gmalinve
Copy link
Contributor

@gmalinve gmalinve commented May 5, 2022

In this PR:

  • Fix in assign_coil() -> polarity is now case insensitive.
  • Fix in assign_winding() -> fix in coil_terminals if its None and voltage, current, res, ind fixes
  • new 2D/3D tests implementation

@gmalinve gmalinve self-assigned this May 5, 2022
This was linked to issues May 5, 2022
Maxwell3d.assign_coil shows errors #1101
Closed
assign_winding in maxwell.py returns errors if calling with default coil_terminals=None #892
Closed
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #1147 (9b19079) into main (1696e50) will increase coverage by 0.09%.
The diff coverage is 98.30%.

@@            Coverage Diff             @@
##             main    #1147      +/-   ##
==========================================
+ Coverage   80.49%   80.59%   +0.09%     
==========================================
  Files         134      134              
  Lines       42877    42995     +118     
==========================================
+ Hits        34515    34651     +136     
+ Misses       8362     8344      -18

maxcapodi78
maxcapodi78 approved these changes May 5, 2022
View reviewed changes
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmalinve gmalinve merged commit ffecfbe into main May 5, 2022
@gmalinve gmalinve deleted the Maxwell_Assign_Coil branch May 5, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcapodi78 maxcapodi78 maxcapodi78 approved these changes

Assignees

@gmalinve gmalinve

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maxwell3d.assign_coil shows errors assign_winding in maxwell.py returns errors if calling with default coil_terminals=None
2 participants
@gmalinve @maxcapodi78