Handling Maxwell Circuit Variables #1046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 15, 2022 14:19
# Conflicts: # _unittest/test_09_VariableManager.py # pyaedt/application/Design.py
Codecov Report
@@ Coverage Diff @@
## main #1046 +/- ##
==========================================
+ Coverage 80.36% 80.38% +0.01%
==========================================
Files 132 132
Lines 40496 40552 +56
==========================================
+ Hits 32545 32598 +53
- Misses 7951 7954 +3 |
MaxJPRey
reviewed
Apr 15, 2022
pyaedt/application/Design.py
Outdated
| val_units = self._odesign.GetVariableValue(variable_name) | ||
| val, units = decompose_variable_value(val_units) | ||
| try: | ||
| float(val) |
There was a problem hiding this comment.
@maxcapodi78 I am not sure it is mandatory as we are returning the expression the line after.
Suggested change
| float(val) |
There was a problem hiding this comment.
not sure either.... I'll check better
MaxJPRey
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.