Doc/update edb doc #1032
Merged
Doc/update edb doc #1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add that LayerType = 1 is for dielectric.
Added additional layer types from the EDB documentation to the docstring:
``2``: Conducting plane layer.
``3``: Airline layer.
``4``: Error layer.
``5``: Symbol layer.
``6``: Measure layer.
``8``: Assembly layer.
``9``: Silkscreen layer.
``10``: Solder Mask layer.
``11``: Solder Paste layer.
The whole example was re-written based on the original version. There are no longer class definitions in the example. The cutout on the stripline layer allows for a smoother transition from the via. The previous example could have the ground very close to the signal layer at the transition.
This example runs as-is, but the ground planes are not connected. I added a note at the end pointing this out.
Codecov Report
@@ Coverage Diff @@
## main #1032 +/- ##
=======================================
Coverage 80.68% 80.68%
=======================================
Files 132 132
Lines 39663 39663
=======================================
Hits 32004 32004
Misses 7659 7659 |
MaxJPRey
approved these changes
Apr 8, 2022
var_server is not used anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-factoring of the example 04_edb_parameterized_design.py. I merged main into this branch prior to the merge.