Refactored DesignXPloration.py classes to support vaiables customization #1003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1003 +/- ##
==========================================
+ Coverage 80.64% 80.67% +0.02%
==========================================
Files 130 130
Lines 38535 38575 +40
==========================================
+ Hits 31078 31119 +41
+ Misses 7457 7456 -1 |
Alberto-DM
reviewed
Mar 28, 2022
| @@ -568,7 +568,7 @@ def test_24_create_curvilinear(self): | |||
| def test_25_create_parametrics(self): | |||
| self.aedtapp["w1"] = "10mm" | |||
| self.aedtapp["w2"] = "2mm" | |||
| setup1 = self.aedtapp.parametrics.add({"w1": "LIN 0.1mm 20mm 0.2mm"}) | |||
| setup1 = self.aedtapp.parametrics.add("w1", 0.1, 20, 0.2, "LinearStep") | |||
| assert setup1 | |||
| assert setup1.add_variation("w2", "0.1mm", 10, 11) | |||
There was a problem hiding this comment.
I understand the logic, but what I find confusing is having 3 methods to do the same thing. parametrics.add, parametrics.set_variation, optimization.add_variable.
There was a problem hiding this comment.
Thanks. I've renamed set_variable to add_variation to keep consistency between optimizations object and parametrics object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.