-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Improve optional arguments in show
#306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMoraisAnsys
approved these changes
Jun 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left a minor comment that you can discard if needed
src/ansys/tools/visualization_interface/backends/pyvista/pyvista.py
Outdated
Show resolved
Hide resolved
…ta.py Co-authored-by: Sébastien Morais <[email protected]>
…rnal/pyansys-visualizer into feat/improve-opt-args
RobPasMue
reviewed
Jun 19, 2025
This was referenced Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes an unexpected behaviour in the
show
method, where optional keyword arguments were being passed only toplot
in case users were passing plottable objects to theshow
method.This caused that optional keyword arguments that needed to be passed to the underlying PyVista method
show
weren't reaching it. If you passed the plottable object and the optional keyword arguments destinated to the pyvistashow
method, an error would be thrown.New behaviour
Now if you need to pass plottable objects directly to
show
, you can pass a dictionary through ``plotting_options` argument where you can add the PyVista plotting options for that plottable object.Before
Now
Associated issues
ansys/pymechanical#1189