feat: dropdown for navigation bar #723
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
Revathyvenugopal162
force-pushed
the
feat/navbar-dropdown
branch
from
29fb239 to
f7b238c
Compare
…-sphinx-theme into feat/navbar-dropdown
jorgepiloto
reviewed
Jun 27, 2025
jorgepiloto
reviewed
Jun 27, 2025
jorgepiloto
reviewed
Jun 27, 2025
jorgepiloto
reviewed
Jun 27, 2025
jorgepiloto
reviewed
Jun 27, 2025
jorgepiloto
reviewed
Jun 27, 2025
| raise ValueError(f"Error parsing YAML file '{navigation_yaml_file}': {exc}") | ||
|
|
||
|
|
||
| NavEntry = Dict[str, Union[str, List["NavEntry"]]] |
There was a problem hiding this comment.
Let's add a docstring for this so we remember its goal.
jorgepiloto
reviewed
Jun 27, 2025
jorgepiloto
requested changes
Jun 27, 2025
There was a problem hiding this comment.
Thanks for adding this feature, @Revathyvenugopal162. I left some suggestions.
Co-authored-by: Jorge Martínez <[email protected]>
Co-authored-by: Jorge Martínez <[email protected]>
…-sphinx-theme into feat/navbar-dropdown
germa89
reviewed
Jun 30, 2025
germa89
reviewed
Jun 30, 2025
germa89
reviewed
Jun 30, 2025
germa89
reviewed
Jun 30, 2025
germa89
approved these changes
Jun 30, 2025
…-sphinx-theme into feat/navbar-dropdown
Co-authored-by: German <[email protected]>
germa89
reviewed
Jun 30, 2025
| divs = li.find_all("div", {"class": "navbar-dropdown"}, recursive=False) | ||
| if divs: | ||
| ref = li.find("div", {"class": "ref-container"}) | ||
| ref.append(soup.new_tag("i", attrs={"class": "fa-solid fa-chevron-down"})) |
There was a problem hiding this comment.
I like that the chevrons have their class, so it is easier to customise it through CSS files.
I wonder if you have set an specific class name for the items in each dropdown, so we can do something similar (or use bs4 easily on them).
There was a problem hiding this comment.
yes, We have the specific container for navbar-dropdown as you can see in the line L#131.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
This PR introduces support for a dropdown list in the navigation bar, allowing users to enable this option if desired.
Images
Images included below to showcase the updated navigation bar and dropdown functionality.
