Skip to content

Remove redundant fixtures from tests/fixtures/common directory #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 25, 2025
Merged

Remove redundant fixtures from tests/fixtures/common directory #403

merged 5 commits into from
Apr 25, 2025

Conversation

shatakshiiii
Copy link
Contributor

@shatakshiiii shatakshiiii commented Apr 23, 2025 •
edited
Loading

SUMMARY

  • Move role_galaxy method to a more appropriate location inside add.py
  • Remove the redundant fixture devfile.yaml from tests/fixtures/common directory.
  • Remove the redundant fixture role from tests/fixtures/common directory.
  • Update test_add.py to utilise existing fixtures present inside FIXTURES_DIR / "collection" / "testorg" / "testcol"

JIRA: AAP-44157
Related: #398

@shatakshiiii shatakshiiii added the enhancement New feature or request label Apr 23, 2025
@shatakshiiii shatakshiiii changed the title Remove unnecessary files from tests/fixtures/common directory Remove redundant fixtures from tests/fixtures/common directory Apr 25, 2025
@shatakshiiii shatakshiiii reopened this Apr 25, 2025
@shatakshiiii shatakshiiii marked this pull request as ready for review April 25, 2025 11:35
@shatakshiiii shatakshiiii requested a review from a team as a code owner April 25, 2025 11:35
@shatakshiiii shatakshiiii requested a review from cidrblock April 25, 2025 11:35
cidrblock
cidrblock approved these changes Apr 25, 2025
View reviewed changes
Copy link
Collaborator

@cidrblock cidrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great cleanup

@ssbarnea ssbarnea merged commit 1067711 into ansible:main Apr 25, 2025
34 checks passed
@shatakshiiii shatakshiiii deleted the test_refactor branch April 25, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@cidrblock cidrblock cidrblock approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shatakshiiii @ssbarnea @cidrblock