Skip to content

Allow adding internal comment on JSD #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2025

Conversation

dynek
Copy link
Contributor

@dynek dynek commented Feb 25, 2025

issue comment add currently only allows creating public comments.
This MR makes it so creating internal comments is possible using the --internal flag , useful on Jira Service Management/Desk.

@ankitpokhrel ankitpokhrel force-pushed the allow_jsd_internal_comments branch from c6d35b8 to c3838b1 Compare March 23, 2025 09:19
Copy link
Owner

@ankitpokhrel ankitpokhrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't test it fully but it doesn't seem to break anything. Looks good to merge!

Thank you for working on this!

@ankitpokhrel ankitpokhrel merged commit 1278c80 into ankitpokhrel:main Mar 23, 2025
4 checks passed
@dynek
Copy link
Contributor Author

dynek commented Mar 24, 2025

Thank you @ankitpokhrel - do you plan a new release soon ?

@ankitpokhrel
Copy link
Owner

@dynek I don't have a fixed timeline but I'll try to do it soon, probably within the next few weeks.

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Apr 26, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ankitpokhrel/jira-cli](https://github.com/ankitpokhrel/jira-cli) | minor | `v1.5.2` -> `v1.6.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>ankitpokhrel/jira-cli (ankitpokhrel/jira-cli)</summary>

### [`v1.6.0`](https://github.com/ankitpokhrel/jira-cli/releases/tag/v1.6.0)

[Compare Source](ankitpokhrel/jira-cli@v1.5.2...v1.6.0)

This release comes with some fixes and features like JSON-formatted issue‑creation output, multi‑string replacements in issue clone, internal JSD comments, etc.

#### 🥷 What's added?

-   feat: Respect API token for `mtls` auth by [@&#8203;LucasZanellaMBTI](https://github.com/LucasZanellaMBTI) in ankitpokhrel/jira-cli#783
-   feat: Add option to output issue creation result as Json by [@&#8203;sebbbastien](https://github.com/sebbbastien) in ankitpokhrel/jira-cli#775
-   feat: Allow multiple replace strings in issue clone command by [@&#8203;AdamSaleh](https://github.com/AdamSaleh) in ankitpokhrel/jira-cli#811
-   feat: Allow adding internal comment on JSD by [@&#8203;dynek](https://github.com/dynek) in ankitpokhrel/jira-cli#825
-   feat: Add easy issue search to list cmd by [@&#8203;wbh1](https://github.com/wbh1) in ankitpokhrel/jira-cli#769

#### 🐞 What's fixed?

-   fix: Case-insensitive sub-task comparison by [@&#8203;tiemma](https://github.com/tiemma) in ankitpokhrel/jira-cli#793
-   fix: use `tview.Escape` with standard square brackets by [@&#8203;rpadaki](https://github.com/rpadaki) in ankitpokhrel/jira-cli#828, ankitpokhrel/jira-cli#839

#### ☕️ Other changes

-   Add shell completion to brew install; closes [#&#8203;651](ankitpokhrel/jira-cli#651) by [@&#8203;MarkIannucci](https://github.com/MarkIannucci) in ankitpokhrel/jira-cli#795
-   Update golang.org/x/net package to version 0.33.0 by [@&#8203;sanjushahgupta](https://github.com/sanjushahgupta) in ankitpokhrel/jira-cli#806
-   Fix lint issues by [@&#8203;sanjushahgupta](https://github.com/sanjushahgupta) in ankitpokhrel/jira-cli#808
-   chore(deps): bump golang.org/x/net from 0.33.0 to 0.36.0 by [@&#8203;dependabot](https://github.com/dependabot) in ankitpokhrel/jira-cli#831
-   chore(deps): Upgrade spinner, glamour, go-keyring and related deps by [@&#8203;ankitpokhrel](https://github.com/ankitpokhrel) in ankitpokhrel/jira-cli#833
-   chore(deps): bump golang.org/x/net from 0.37.0 to 0.38.0 by [@&#8203;dependabot](https://github.com/dependabot) in ankitpokhrel/jira-cli#838

#### New Contributors

-   [@&#8203;sanjushahgupta](https://github.com/sanjushahgupta) made their first contribution in ankitpokhrel/jira-cli#806
-   [@&#8203;tiemma](https://github.com/tiemma) made their first contribution in ankitpokhrel/jira-cli#793
-   [@&#8203;LucasZanellaMBTI](https://github.com/LucasZanellaMBTI) made their first contribution in ankitpokhrel/jira-cli#783
-   [@&#8203;rpadaki](https://github.com/rpadaki) made their first contribution in ankitpokhrel/jira-cli#828
-   [@&#8203;sebbbastien](https://github.com/sebbbastien) made their first contribution in ankitpokhrel/jira-cli#775
-   [@&#8203;AdamSaleh](https://github.com/AdamSaleh) made their first contribution in ankitpokhrel/jira-cli#811
-   [@&#8203;dynek](https://github.com/dynek) made their first contribution in ankitpokhrel/jira-cli#825
-   [@&#8203;MarkIannucci](https://github.com/MarkIannucci) made their first contribution in ankitpokhrel/jira-cli#795
-   [@&#8203;wbh1](https://github.com/wbh1) made their first contribution in ankitpokhrel/jira-cli#769

**Full Changelog**: ankitpokhrel/jira-cli@v1.5.2...v1.6.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yNTMuMCIsInVwZGF0ZWRJblZlciI6IjM5LjI1My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants