Try to detect if JIRA v8 server is not using the Createmeta REST endpoint #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @tristianc, thank you for the fix.
As per the docs, it seems like this new endpoint is already available in 8.4.
That is why we decided to remove this endpoint in Jira 9.0. Until then you can disable it and
replace it with the other calls we've created and made available in Jira 8.4 to remedy the issue.
Since the new endpoint is already available in Jira v8.4, I think it is safe to change the version comparison in line 472 to make it work above v8.4.
isV9Compatible := c.value.version.major >= 9 || (c.value.version.major == 8 && c.value.version.minor >= 4)
if c.value.installation == jira.InstallationTypeLocal && isV9Compatible {
err = c.configureIssueTypesForJiraServerV9()
} else {
...
}
internal/config/generator.go
Outdated
| @@ -473,6 +473,13 @@ func (c *JiraCLIConfigGenerator) configureMetadata() error { | |||
| err = c.configureIssueTypesForJiraServerV9() | |||
| } else { | |||
| err = c.configureIssueTypes() | |||
| if err != nil { | |||
| if e, ok := err.(*url.Error); ok { | |||
| if e.Err.Error() == "303 response missing Location header" && c.value.version.major == 8 && c.value.version.minor >= 4 { | |||
There was a problem hiding this comment.
This is required only for the local installation
ankitpokhrel
approved these changes
Mar 18, 2023
|
Thank you @tristianc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I try to log into our JIRA instance, I get:
This is with commit 6085aee, committed on February 13th.
When I attempted to try the last endpoint (
/rest/api/2/issue/createmeta?projectKeys=CD&expand=projects.issuetypes.fields) myself in a browser manually, I get:The behavior of our v8 instance matches the default behavior of JIRA v9, which the CLI already accomodates. This tries to detect if the v9 behavior should be used for v8.