Skip to content

feat: Allow insecure TLS #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2022
Merged

feat: Allow insecure TLS #305

merged 1 commit into from
Feb 20, 2022

Conversation

ankitpokhrel
Copy link
Owner

This PR adds an --insecure option in init cmd to skip TLS verification. This can be useful if the Jira server is using self-signed certificates.

Relates to: #271 (comment)

@ankitpokhrel ankitpokhrel marked this pull request as ready for review February 20, 2022 18:50
@ankitpokhrel ankitpokhrel merged commit dc13ad3 into main Feb 20, 2022
@ankitpokhrel ankitpokhrel deleted the patch-tls-issue branch February 20, 2022 18:54
@ankitpokhrel ankitpokhrel added this to the v1.0.0 milestone Apr 30, 2022
@MattPD
Copy link

MattPD commented Jul 22, 2022

I've just checked this option after the 1.0.0 release, but I cannot go past the init step:

jira init --insecure
You are using --insecure option. In this mode, the client will NOT verify
server's certificate chain and host name in requests to the jira server.

? Config already exist. Do you want to overwrite? Yes
? Installation type: Local
? Link to Jira server: (MY_SERVER)
? Login username: (MY_USERNAME)

✗ Unable to generate configuration: x509: certificate signed by unknown authority

FWIW , the previous workaround (in github.com/ankitpokhrel/jira-cli/cmd/jira@patch-tls-issue) worked for me.

@ankitpokhrel
Copy link
Owner Author

Hi @MattPD, it looks like an issue with config generator. Does it work for you if you manually add this line in your config yaml file?

insecure: true

ankitpokhrel added a commit that referenced this pull request Jul 27, 2022
ankitpokhrel added a commit that referenced this pull request Jul 27, 2022
@MattPD
Copy link

MattPD commented Jul 28, 2022

Thanks, yes, adding insecure: true to the ~/.config/.jira/.config.yml did the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants