Skip to content

fix: controls settings being removed after selecting tab #18796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

BrayanDSO
Copy link
Member

@BrayanDSO BrayanDSO commented Jul 6, 2025

Purpose / Description

this issue happened after I removed the General settings category on Controls

Screenrecorder-2025-07-06-15-20-25-261.mp4

Approach

Remove only the items after the ControlTabsPreference. I tried to make a test for it, but had some trouble getting a reference to the TabLayout

How Has This Been Tested?

Emulator API 36:

normal.mp4

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jul 8, 2025
@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jul 8, 2025
@lukstbit lukstbit added this pull request to the merge queue Jul 8, 2025
Merged via the queue into ankidroid:main with commit bdc282b Jul 8, 2025
12 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jul 8, 2025
@github-actions github-actions bot added this to the 2.21 release milestone Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants