build(deps): adopt anki 25.07.1 on release branch #18783
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added: * getIgnoredBeforeCountRaw * getRetentionWorkloadRaw removed: * importJsonString ---- The definition of a month was changed in https://redirect.github.com/ankitects/anki/pull/3901 so: "10.8mo" => "10.7mo" ---- PartiallyRenderedCard.is_empty was added Co-authored-by: David Allison <[email protected]> (cherry picked from commit 42a065e)
* evaluateParams -> evaluateParamsLegacy * importJsonString was re-added (cherry picked from commit 05114c2)
|
I was pleased to see this was possible, but it was always proof of concept, and current plan is integration and release from main: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Discord, we believe these things:
So this PR continues the theme of "feasibility check" for the anki-25.05/6/7 releases that we've been doing. It could work, and be useful in the future, or it could go nowhere and close unmerged.
Either way, we'll have CI feedback, and will do whatever seems right based on a future consensus
It is a cherry-pick of these two PRs (both of which were a single commit):