Skip to content

Add config option to skip clear_helpers #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add config option to skip clear_helpers #316

wants to merge 1 commit into from

Conversation

denny
Copy link

@denny denny commented Dec 17, 2020

Adds a config option to skip the clear_helpers call in the base controller; fixes my issue #315

@ankane
Copy link
Owner

ankane commented Jan 2, 2021

Hey @denny, thanks for the PR! Blazer views aren't designed to wrapped in application templates, so don't want to add an option for it, but you can probably add the helpers back manually if needed.

@ankane
Copy link
Owner

ankane commented Jan 29, 2021

Cleaning up PRs

@denny
Copy link
Author

denny commented Jan 30, 2021

In case anybody else does trip over this, here's what I have in my ApplicationController now:

def self.clear_helpers
  super unless self == Blazer::BaseController
end

(Pretty sure I wouldn't want anything else to do it either, but I figured it was safest to override the minimum necessary for now.)

@denny denny deleted the config-clear-helpers branch January 30, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants