Skip to content

fix(@angular/ssr): correctly resolve pre-transform resources in Vite SSR without AppEngine #29144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

alan-agius4
Copy link
Collaborator

Ensure proper resolution of pre-transform resources when using SSR in Vite without relying on AppEngine.

Closes #29132

…SSR without AppEngine

Ensure proper resolution of pre-transform resources when using SSR in Vite without relying on AppEngine.

Closes angular#29132
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Dec 16, 2024
@alan-agius4 alan-agius4 requested a review from clydin December 16, 2024 13:27
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer and removed target: minor This PR is targeted for the next minor release action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Dec 16, 2024
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 16, 2024
@alan-agius4 alan-agius4 merged commit 1bf9381 into angular:main Dec 16, 2024
37 checks passed
@alan-agius4 alan-agius4 deleted the ssr-vite-resource branch December 16, 2024 14:03
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 19.0.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/ssr target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Children routes triggering Vite log error: '[vite] Pre-transform error: Failed to load url'
2 participants