fix(@schematics/angular): replace existing BrowserModule.withServerTransition calls when running universal schematic
#24564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: patch
clydin
approved these changes
Jan 18, 2023
alan-agius4
changed the title
BrowserModule.withServerTransition calls when running universal schematicBrowserModule.withServerTransition calls when running universal schematic
…ransition` calls when running universal schematic This change fixes an issue where calling the universal schematic on an application with existing `BrowserModule.withServerTransition` will cause an additional `.withServerTransition` call to be added. With this change we now remove the previous `withServerTransition` call to avoid misconfiguration. Closes angular#24563
alan-agius4
force-pushed
the
with-transition-replace
branch
from
b653deb to
ad83d24
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue where calling the universal schematic on an application with existing
BrowserModule.withServerTransitionwill cause an additional.withServerTransitioncall to be added.With this change we now remove the previous
withServerTransitioncall to avoid misconfiguration.Closes #24563