fix(PeriphDrivers,Examples): Remove I2C Rev B and fix bugs in MXC_I2C_RevA_SlaveAsyncHandler #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
MAX32650
Jacob-Scheiffler
changed the title
Jacob-Scheiffler
changed the title
Jacob-Scheiffler
changed the title
Jake-Carter
approved these changes
Aug 25, 2023
sihyung-maxim
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MAX32650 was the only chip which uses the I2C Rev. B source code, most of which were pass through calls to I2C Rev. A. Because of this redundancy, this PR remove all I2C Rev. B collateral and ports the MAX32650 source code to use I2C Rev. A.
Additionally, by accident I included the changes that were previously in #715, which fixed an error in the MXC_I2C_RevA_SlaveAsyncHandler by properly handling the DONE interrupt. This allows for our I2C examples to be run at speeds higher than 100kHz.