fix(Build): Disable Parallel Execution When Creating common_riscv.ld for RISCV_LOAD=1
#704
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
As of #653 some build errors starting showing up in the auto-tester, but just for the AI85 Aud01_RevA BSP. (ex here, here)
This turned out to be an issue with parallel builds. RV_ARM_Loader for the AI85/AI87 failed for other boards with
make -r -j
, but randomly. The rule for creatingriscv_common.ld
seems to have an incomplete dependency tree. I tried several solutions to make the dependency tree more explicit, but nothing seemed to work. The file operations for parsing the .map file for the RISC-V boot address always had some chance of modifying files that were being worked on by other parallel threads.TLDR: As a solution, I've disabled parallel builds for the step where
RISCV_LOAD=1
createsriscv_common.ld
. Impact on build speed is minimal, and this seems to work.Checklist Before Requesting Review