Skip to content

fix(Build): Disable Parallel Execution When Creating common_riscv.ld for RISCV_LOAD=1 #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Jake-Carter
Copy link
Contributor

@Jake-Carter Jake-Carter commented Aug 10, 2023

Pull Request Template

Description

As of #653 some build errors starting showing up in the auto-tester, but just for the AI85 Aud01_RevA BSP. (ex here, here)

This turned out to be an issue with parallel builds. RV_ARM_Loader for the AI85/AI87 failed for other boards with make -r -j, but randomly. The rule for creating riscv_common.ld seems to have an incomplete dependency tree. I tried several solutions to make the dependency tree more explicit, but nothing seemed to work. The file operations for parsing the .map file for the RISC-V boot address always had some chance of modifying files that were being worked on by other parallel threads.

TLDR: As a solution, I've disabled parallel builds for the step where RISCV_LOAD=1 creates riscv_common.ld. Impact on build speed is minimal, and this seems to work.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@github-actions github-actions bot added MAX78000 Related to the MAX78000 (AI85) MAX78002 Related to the MAX78002 (AI87) labels Aug 10, 2023
@Jake-Carter Jake-Carter added the build system This issue or pull request is related to the MSDK build system label Aug 10, 2023
@Jake-Carter Jake-Carter merged commit 2fa4a0a into analogdevicesinc:main Aug 10, 2023
@Jake-Carter Jake-Carter deleted the fix/rv_arm_loader-parallel branch August 10, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system This issue or pull request is related to the MSDK build system MAX78000 Related to the MAX78000 (AI85) MAX78002 Related to the MAX78002 (AI87)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants