Skip to content

build(PeriphDrivers): Untrack Pre-built PeriphDriver Libraries #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Jake-Carter
Copy link
Contributor

@Jake-Carter Jake-Carter commented Aug 8, 2023

Pull Request Template

Description

This PR removes the pre-built PeriphDriver library files from our repo. They cause constant conflicts, frequently get outdated, and have generally no benefit other than saving 10 seconds of initial build time.

It also removes the workflow that auto rebuilds the PeriphDriver lib files for the release branch, which has steadily caused release and main to get out of sync.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@github-actions github-actions bot added the Workflow Related to Workflow development label Aug 8, 2023
Copy link
Contributor

@sihyung-maxim sihyung-maxim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also exclude these files in .gitignore?

@Jake-Carter Jake-Carter force-pushed the dev/untrack-periphdrivers branch from 647cf20 to 076c1b9 Compare August 10, 2023 19:55
@Jake-Carter Jake-Carter merged commit eb6b766 into analogdevicesinc:main Aug 10, 2023
@Jake-Carter Jake-Carter deleted the dev/untrack-periphdrivers branch August 10, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Workflow Related to Workflow development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants