fix(PeriphDrivers): Explicitly set the LPCMP Polarity Setting (Rising/Falling) #697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
MXC_LPCMP_POL_RISE
andMXC_LPCMP_POL_FALL
enumeration values are used to set the polarity setting for the LPCMP. However, they weren't explicitly set with the values 0 and 1, respectively, which can cause the H->L transition setting to be selected when using theMXC_LPCMP_POL_RISE
enum value (should beMXC_LPCMP_POL_FALL
that selects the H->L transition setting) and vice versa.Checklist Before Requesting Review