Skip to content

fix(PeriphDrivers): Explicitly set the LPCMP Polarity Setting (Rising/Falling) #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

sihyung-maxim
Copy link
Contributor

@sihyung-maxim sihyung-maxim commented Aug 4, 2023

Description

The MXC_LPCMP_POL_RISE and MXC_LPCMP_POL_FALL enumeration values are used to set the polarity setting for the LPCMP. However, they weren't explicitly set with the values 0 and 1, respectively, which can cause the H->L transition setting to be selected when using the MXC_LPCMP_POL_RISE enum value (should be MXC_LPCMP_POL_FALL that selects the H->L transition setting) and vice versa.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@github-actions github-actions bot added MAX32655 Related to the MAX32655 (ME17) MAX32680 Related to the MAX32680 (ME20) MAX32690 Related to the MAX32690 (ME18) MAX78000 Related to the MAX78000 (AI85) MAX78002 Related to the MAX78002 (AI87) labels Aug 4, 2023
@sihyung-maxim sihyung-maxim merged commit ba0dcbd into main Sep 5, 2023
@sihyung-maxim sihyung-maxim deleted the fix/lpcmp_polsel branch September 5, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAX32655 Related to the MAX32655 (ME17) MAX32680 Related to the MAX32680 (ME20) MAX32690 Related to the MAX32690 (ME18) MAX78000 Related to the MAX78000 (AI85) MAX78002 Related to the MAX78002 (AI87)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants