Update readme MacOS M1 instructions #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinking-binaries
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
I checked these new instructions against my bash history, and they are much clearer now thanks.
Just one note, brew has a feature brew shellenv that can be used to ensure the correct environment variables are set for that version of brew. However, I /think/ brew might do this internally itself before it runs, as your instructions if followed to the letter did correctly install the i386 dynlib binaries in the i386 version of brew's Cellar fine, even though I also have the arm64 version of brew installed as well.
Thanks for adding the clarifications to this readme.
sihyung-maxim
approved these changes
Nov 28, 2022
Jacob-Scheiffler
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some more insightful instructions on the Homebrew installation procedure for MacOS running on Apple Silicon, especially for users who may already have the arm64 version of Homebrew installed.
Resolves #259