chore: Use text-unidecode instead of unidecode package to fix license incompatibility #2168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update databuilder to use
text-unidecode
instead ofunidecode
due to license incompatibility issuesUnrelated to the main change, now also ignoring the
None
type passed topyparsing
'snestedExpr
function. In the docstring for this function, it specifically saysif no expressions are to be ignored, then pass ``None`` for this argument.
so the type definition for the function is incorrect and this is a workaroundMotivation and Context
This fixes license incompatibility issues, since Amundsen is licensed under Apache 2.0 and
unidecode
is GPL. See this issue for further context: #2148How Has This Been Tested?
Python tests pass
Documentation
N/A
CheckList