Skip to content

chore: Use text-unidecode instead of unidecode package to fix license incompatibility #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

kristenarmes
Copy link
Contributor

@kristenarmes kristenarmes commented Jun 14, 2023

Description

  • Update databuilder to use text-unidecode instead of unidecode due to license incompatibility issues

  • Unrelated to the main change, now also ignoring the None type passed to pyparsing's nestedExpr function. In the docstring for this function, it specifically says if no expressions are to be ignored, then pass ``None`` for this argument. so the type definition for the function is incorrect and this is a workaround

Motivation and Context

This fixes license incompatibility issues, since Amundsen is licensed under Apache 2.0 and unidecode is GPL. See this issue for further context: #2148

How Has This Been Tested?

Python tests pass

Documentation

N/A

CheckList

  • PR title addresses the issue accurately and concisely
  • Updates Documentation and Docstrings
  • Adds tests
  • Adds instrumentation (logs, or UI events)

@boring-cyborg boring-cyborg bot added the area:databuilder From databuilder folder label Jun 14, 2023
@kristenarmes kristenarmes marked this pull request as ready for review June 14, 2023 01:38
@kristenarmes kristenarmes requested a review from a team as a code owner June 14, 2023 01:38
Copy link
Contributor

@ozandogrultan ozandogrultan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we bump up the version of databuilder in setup.py?

Signed-off-by: Kristen Armes <[email protected]>
Copy link
Contributor

@ozandogrultan ozandogrultan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kristenarmes kristenarmes merged commit 13a6996 into main Jun 14, 2023
@kristenarmes kristenarmes deleted the karmes-update-unidecode-pkg branch June 14, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:databuilder From databuilder folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants