Skip to content

style - Truncate long notice modal text with ellipsis #2152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 17, 2023
Merged

style - Truncate long notice modal text with ellipsis #2152

merged 3 commits into from
May 17, 2023

Conversation

B-T-D
Copy link
Contributor

@B-T-D B-T-D commented May 15, 2023

Description

When the text of an item in the notice modal is too long for its container, it looks better for it to truncate with an ellipsis rather than wrapping.

How Has This Been Tested?

Manually.

Documentation

CheckList

  • PR title addresses the issue accurately and concisely
  • Updates Documentation and Docstrings
  • Adds tests
  • Adds instrumentation (logs, or UI events)

@B-T-D
Adjust styling
668b365 
Signed-off-by: Ben Dye <[email protected]>
@boring-cyborg boring-cyborg bot added the area:frontend From the Frontend folder label May 15, 2023
@B-T-D
use inline JSX styling
c584c88 
Signed-off-by: Ben Dye <[email protected]>
@B-T-D B-T-D marked this pull request as ready for review May 15, 2023 18:36
allisonsuarez
allisonsuarez reviewed May 16, 2023
View reviewed changes
frontend/amundsen_application/static/js/components/DefinitionList/index.tsx Outdated
@@ -35,7 +35,14 @@ export const DefinitionList: React.FC<DefinitionListProps> = ({
</dt>
<dd className="definition-list-definition">
{typeof description === 'string' ? (
<SanitizedHTML html={description} />
<SanitizedHTML
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't usually do inline styling, and it seems you added these to a class on css as well so can you use that instead?

@B-T-D B-T-D merged commit 3a76b29 into main May 17, 2023
@B-T-D B-T-D deleted the btd-truncate-long-modal-text branch May 17, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonsuarez allisonsuarez allisonsuarez approved these changes

@Golodhros Golodhros Awaiting requested review from Golodhros Golodhros is a code owner

@ttannis ttannis Awaiting requested review from ttannis ttannis is a code owner

@feng-tao feng-tao Awaiting requested review from feng-tao feng-tao is a code owner

@dorianj dorianj Awaiting requested review from dorianj

@verdan verdan Awaiting requested review from verdan verdan is a code owner

@mgorsk1 mgorsk1 Awaiting requested review from mgorsk1 mgorsk1 is a code owner

@sewardgw sewardgw Awaiting requested review from sewardgw sewardgw is a code owner

@youngyjd youngyjd Awaiting requested review from youngyjd youngyjd is a code owner

@dechoma dechoma Awaiting requested review from dechoma dechoma is a code owner

@kristenarmes kristenarmes Awaiting requested review from kristenarmes kristenarmes is a code owner

Assignees
No one assigned
Labels
area:frontend From the Frontend folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@B-T-D @allisonsuarez