style – Adjust margin on elements inside the Alert component #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Dye <[email protected]>
B-T-D
requested review from
Golodhros,
ttannis,
allisonsuarez,
feng-tao,
dorianj,
verdan,
mgorsk1,
sewardgw,
youngyjd,
dechoma and
kristenarmes
as code owners
kristenarmes
reviewed
May 3, 2023
| $alert-warning-background: #fff0d4; | ||
| $alert-alert-background: #ffe4dd; | ||
| $alert-element-margin: auto 0 auto auto; |
There was a problem hiding this comment.
the top and bottom margins look good in the screenshot now, but the message is a little far over from the icon IMO. maybe we can have two separate margin values here, this one you have used for the alert-action, then auto auto auto 0 used for the alert-message so that we can have 0 on the left side like before
Signed-off-by: Ben Dye <[email protected]>
kristenarmes
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The vertical alignment was inconsistent between different elements inside the Alert component. This PR adjusts the margins to make the Alert look better and properly aligned.
How the Alert component looked before:
After:
How Has This Been Tested?
Manually. Building locally with the change and visually inspecting.
Documentation
None
CheckList