Skip to content

fix - Increase width in resource notice modal #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2023
Merged

fix - Increase width in resource notice modal #2146

merged 2 commits into from
May 2, 2023

Conversation

B-T-D
Copy link
Contributor

@B-T-D B-T-D commented Apr 25, 2023

Description

We found that the width of the label column was somewhat too small.

Motivation and Context

How Has This Been Tested?

Manually. Ran locally with different values to inspect the visual difference.

Documentation

None

CheckList

  • PR title addresses the issue accurately and concisely
  • Updates Documentation and Docstrings
  • Adds tests
  • Adds instrumentation (logs, or UI events)

@boring-cyborg boring-cyborg bot added the area:frontend From the Frontend folder label Apr 25, 2023
Golodhros
Golodhros reviewed Apr 25, 2023
View reviewed changes
frontend/amundsen_application/static/js/components/Alert/Alert.tsx Outdated
@@ -153,7 +153,7 @@ export const Alert: React.FC<AlertProps> = ({
<Modal.Title>{PAYLOAD_MODAL_TITLE}</Modal.Title>
</Modal.Header>
<Modal.Body>
<DefinitionList definitions={payloadDefinitions} termWidth={120} />
<DefinitionList definitions={payloadDefinitions} termWidth={180} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this a constant, maybe naming it DEFINITION_WIDTH

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, will do

@B-T-D B-T-D marked this pull request as ready for review May 2, 2023 18:58
@B-T-D B-T-D merged commit 6b593bc into amundsen-io:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Golodhros Golodhros Golodhros left review comments

@kristenarmes kristenarmes kristenarmes approved these changes

@ttannis ttannis Awaiting requested review from ttannis ttannis is a code owner

@allisonsuarez allisonsuarez Awaiting requested review from allisonsuarez allisonsuarez is a code owner

@feng-tao feng-tao Awaiting requested review from feng-tao feng-tao is a code owner

@dorianj dorianj Awaiting requested review from dorianj

@verdan verdan Awaiting requested review from verdan verdan is a code owner

@mgorsk1 mgorsk1 Awaiting requested review from mgorsk1 mgorsk1 is a code owner

@sewardgw sewardgw Awaiting requested review from sewardgw sewardgw is a code owner

@youngyjd youngyjd Awaiting requested review from youngyjd youngyjd is a code owner

@dechoma dechoma Awaiting requested review from dechoma dechoma is a code owner

Assignees
No one assigned
Labels
area:frontend From the Frontend folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@B-T-D @Golodhros @kristenarmes