Skip to content

chore - Update ubuntu version for python unit tests #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

B-T-D
Copy link
Contributor

@B-T-D B-T-D commented Apr 6, 2023

Description

Updates ubuntu version to 22.04 LTS for the github actions unit tests runner image.

Motivation and Context

Python unit tests being run through GitHub Actions were getting stuck, likely due to GitHub Actions planning to deprecate Ubuntu 18.04 (https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/). This PR replaces 18.04 with 22.04 LTS in the affected workflows.

The diff changing single quotes to double quotes was due to an auto formatter running locally, it's consistent with code style elsewhere in these yaml files.

How Has This Been Tested?

I tested the ubuntu version upgrade by checking out an existing PR whose Python unit tests were stuck, making a new branch, updating the version there, pushing, and creating a PR to trigger the CI. The existing tests then passed.

Documentation

CheckList

  • PR title addresses the issue accurately and concisely
  • Updates Documentation and Docstrings
  • Adds tests
  • Adds instrumentation (logs, or UI events)

@B-T-D B-T-D marked this pull request as ready for review April 6, 2023 00:04
@B-T-D B-T-D requested a review from a team as a code owner April 6, 2023 00:04
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@B-T-D B-T-D merged commit 0b6769e into main Apr 6, 2023
@B-T-D B-T-D deleted the btd-ubuntu-version-python-unit-tests branch April 6, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants