chore: event logging in EditableText component #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Golodhros
requested review from
ttannis,
allisonsuarez,
feng-tao,
dorianj,
verdan,
mgorsk1,
sewardgw,
youngyjd,
dechoma and
kristenarmes
as code owners
Golodhros
force-pushed
the
mi-more-logging
branch
from
3eaaa1a to
80f8c32
Compare
kristenarmes
approved these changes
Apr 4, 2023
frontend/amundsen_application/static/js/components/EditableText/index.spec.tsx
Outdated
Show resolved
Hide resolved
Golodhros
force-pushed
the
mi-more-logging
branch
from
80f8c32 to
fb40627
Compare
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Golodhros
force-pushed
the
mi-more-logging
branch
from
fb40627 to
bfe28f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds logging on EditableText
Tweaks spacing on btn-link
Cleans up ESLint issues and tests
Deprecates use of 'body-2' class
Motivation and Context
Increasing instrumentation on the UI
How Has This Been Tested?
Manually
CheckList