Skip to content

test: Add unit test for quality endpoint, improve message for not-implemented #2127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 30, 2023
Merged

test: Add unit test for quality endpoint, improve message for not-implemented #2127

merged 5 commits into from
Mar 30, 2023

Conversation

B-T-D
Copy link
Contributor

@B-T-D B-T-D commented Mar 29, 2023

Description

  • Adds a simple test for the quality/v0.py endpoint, to have some basic test coverage.
  • Also updates the message returned when a quality checks client isn't configured to be more verbose and descriptive. Based on the analogous message in announcements/v0.py.

Motivation and Context

Test was similar to the one I wrote for the notice endpoint so seemed like an easy opportunity to improve test coverage.

How Has This Been Tested?

Ran the new unit tests locally.

Documentation

Didn't modify any documentation.

CheckList

  • PR title addresses the issue accurately and concisely
  • Updates Documentation and Docstrings
  • Adds tests
  • Adds instrumentation (logs, or UI events)

@B-T-D B-T-D requested a review from a team as a code owner March 29, 2023 15:18
@boring-cyborg boring-cyborg bot added the area:frontend From the Frontend folder label Mar 29, 2023
@B-T-D B-T-D marked this pull request as draft March 29, 2023 15:24
@B-T-D B-T-D marked this pull request as ready for review March 29, 2023 15:27
B-T-D added 3 commits March 30, 2023 12:48
@B-T-D
Trying to trigger stuck CI
13b38bc 
Signed-off-by: Ben Dye <[email protected]>
@B-T-D
Add notice
79d507c 
Signed-off-by: Ben Dye <[email protected]>
@B-T-D
Run Black formatter
e2e8aa0 
Signed-off-by: Ben Dye <[email protected]>
@kristenarmes kristenarmes merged commit 11f54d7 into amundsen-io:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonsuarez allisonsuarez allisonsuarez approved these changes

Assignees
No one assigned
Labels
area:frontend From the Frontend folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@B-T-D @allisonsuarez @kristenarmes