Skip to content

docs: updates the missing application configuration docs #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

Golodhros
Copy link
Member

Description

Updates our Application Configuration docs with the missing items

Motivation and Context

Completing our docs

CheckList

  • PR title addresses the issue accurately and concisely
  • Updates Documentation and Docstrings
  • Adds tests
  • Adds instrumentation (logs, or UI events)

@boring-cyborg boring-cyborg bot added area:docs area:frontend From the Frontend folder labels Mar 24, 2023
@Golodhros Golodhros marked this pull request as ready for review March 24, 2023 22:32
Copy link
Contributor

@allisonsuarez allisonsuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you Marcos

@Golodhros Golodhros merged commit 08785c9 into main Mar 24, 2023
@Golodhros Golodhros deleted the mi-app-config-docs branch March 24, 2023 22:55
Golodhros added a commit that referenced this pull request Mar 24, 2023
B-T-D pushed a commit to B-T-D/amundsen that referenced this pull request Mar 29, 2023
B-T-D pushed a commit to B-T-D/amundsen that referenced this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants