Skip to content

chore: improves UI tracking #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 23, 2023
Merged

chore: improves UI tracking #2122

merged 5 commits into from
Mar 23, 2023

Conversation

Golodhros
Copy link
Member

@Golodhros Golodhros commented Mar 23, 2023

Description

Adds extra tracking events for:

  • Advanced search button
  • Announcements
  • Editable section toggles
  • Bookmarks
  • Notices

Motivation and Context

Improving visibility on user actions

How Has This Been Tested?

Manually

CheckList

  • PR title addresses the issue accurately and concisely
  • Updates Documentation and Docstrings
  • Adds tests
  • Adds instrumentation (logs, or UI events)

@boring-cyborg boring-cyborg bot added the area:frontend From the Frontend folder label Mar 23, 2023
@Golodhros Golodhros marked this pull request as ready for review March 23, 2023 04:50
Copy link
Contributor

@kristenarmes kristenarmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Golodhros Golodhros merged commit e0c2a88 into main Mar 23, 2023
@Golodhros Golodhros deleted the mi-tracking branch March 23, 2023 19:46
B-T-D pushed a commit to B-T-D/amundsen that referenced this pull request Mar 29, 2023
* chore: adds more tracking for advanced search and announcements in the homepage

Signed-off-by: Marcos Iglesias <[email protected]>

* chore: log bookmarks and notice interactions

Signed-off-by: Marcos Iglesias <[email protected]>

* chore: logs editable section toggles

Signed-off-by: Marcos Iglesias <[email protected]>

* chore: updates betterer results

Signed-off-by: Marcos Iglesias <[email protected]>

* chore: mocks analytics for bookmark tests

Signed-off-by: Marcos Iglesias <[email protected]>

---------

Signed-off-by: Marcos Iglesias <[email protected]>
B-T-D pushed a commit to B-T-D/amundsen that referenced this pull request Mar 29, 2023
* chore: adds more tracking for advanced search and announcements in the homepage

Signed-off-by: Marcos Iglesias <[email protected]>

* chore: log bookmarks and notice interactions

Signed-off-by: Marcos Iglesias <[email protected]>

* chore: logs editable section toggles

Signed-off-by: Marcos Iglesias <[email protected]>

* chore: updates betterer results

Signed-off-by: Marcos Iglesias <[email protected]>

* chore: mocks analytics for bookmark tests

Signed-off-by: Marcos Iglesias <[email protected]>

---------

Signed-off-by: Marcos Iglesias <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants